Stick to package-lock.json in actions#4032
Conversation
|
Interesting idea, but I wonder if we shouldn't just remove Because at the moment I'll still generate Normally it's nice to have |
|
I got a bit confused, misguided by this short description. With wildcards now, I wouldn't like letting actions going wild. |
|
That's quite nice. But still doesn't solve the autoupdating of Say we have the following situation:
We now have a merge conflict to deal with. Which can definitely be confusing for Not using wildcards and using dependabot avoids this. But at the cost of noise (having lots of commits). So options are:
No matter what we do here, making the change in this PR is probably good anyway to prevent dependence updates in CI for dependent packages not included in |
|
Ok, so it's not particularly the CI issue, but PR workflow may degrade. But I'd still prefer to have only impactful dependabot PRs. |
|
Yeah could do that. I wonder if it's possible to auto-merge dependabot PRs if CI passes without issue? Will still get some email noise, but at least don't need to manually action them then? But either way this PR is good to merge (as long as we are keeping |
|
Exactly, I'd prefer to keep emails actionable. So I'll merge this and will rollback wildcards if we see it causing conflicts. |
Related to #4021 (comment)